Repository navigation
feat: add app.listRoutes with sub-application support - #7531
Open
bjohansebas wants to merge 1 commit into
Open
bjohansebas wants to merge 1 commit into
bjohansebas wants to merge 1 commit into
Conversation
Member
Author
logaretm
reviewed
Oct 19, 2026
| "qs": "^6.16.0", | ||
| "range-parser": "^1.2.1", | ||
| "router": "^2.2.0", | ||
| "router": "git+https://github.com/bjohansebas/router.git#e59071e415da5983ab901f5d81597b424fda4bdf", |
There was a problem hiding this comment.
Q: This commit isn't in your PR yet, I assume it will?
Member
Author
There was a problem hiding this comment.
It was, but I rebased, so the commit hashes changed. To test it locally, you’ll need to use the latest commit hash from that PR.
There was a problem hiding this comment.
I don't see the wrapper change in listRoutes, there's no handle.router check. I think it had this?
if (!route) {
const handle = layer.handle
const candidate = Array.isArray(handle.stack) ? handle : handle.router // L469
if (candidate && Array.isArray(candidate.stack)) {
router = candidate
}
}Can you double check if it is there?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
app.listRoutes()and expose mounted sub-application routers for nested route inspection, preserving lazy initialization and request handling.Depends on pillarjs/router#174 plus wrapper support;
routeris temporarily pinned to that Git commit.