Repository navigation
fix(channel): 关联账号引导补全,/link 轮询不再闪烁 - #1372
Merged
Merged
Conversation
- 关联账号页只在首次加载显示 spinner,后台 3s 轮询保留关联码;关联成功弹提示 - ownerOnly 与外部 Agent 的 account_user_unbound 回复指向「个人资料 → 关联账号」+ /link - 统一关联码/所有者术语(zh/en/ja)
与 provider 设备码面板一致,用 AutoHeight 包住卡片内容。
Contributor
|
@qqqqqf-q Please complete the following information using the template:
Editing the description triggers another check; format feedback does not block or cancel code CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Author
Type
Summary
外部用户反馈在 IM 里被 Bot 拒绝(「仅机器人所有者…」「没有执行该 Bot 工作区命令的权限」),根因是 所有者的 IM 账号没关联 Memoh 账号;Web 端「个人资料 → 关联账号」已有 /link 流程,但拒绝提示里没有任何指引,用户不知道去哪儿关联。同时关联页在等待 /link 时每 3 秒整块闪成 spinner、关联码消失。
改动:
connected-accounts-section.vue):Pinia Colada 的isLoading在每次后台 refetch 都为 true,3s 轮询refetchBindings时整块被替换成 spinner。改用isPending(只在首次加载为 true),列表和关联码在轮询/KeepAlive 重新激活时保持在屏。关联成功后额外toast.success(用户此时通常在看 IM)。卡片内容用AutoHeight包住,关联码块出现/收起时卡片平滑增高,与 provider 设备码面板一致。cmd.error.ownerOnly:写命令被拒时追加「在 Memoh 网页端「个人资料 → 关联账号」获取关联码,再发送/link <关联码>」。reason=account_user_unbound改用新 keychat.externalAgent.accountUnbound,说明是账号未关联并给出同样的指引;missing_workspace_exec/runtime_owner_mismatch等其他 reason 文案不变。cmd.error.accessDeniedHint统一术语(连接码→关联码、拥有者→所有者;en connection code→link code;ja 接続コード→リンクコード)。settings.connectedAccounts.linked。三语(zh/en/ja)同步,Web 侧也补了chat.externalAgent.accountUnbound以保持两边 key 一致。已确认:关联后所有者会经
channelaccess.inheritedManage获得写命令权限,外部 Agent 的 workspace_exec 检查也会以关联的 user 通过,所以指引的动作确实能解决问题。对 Cloud 的影响:只改文案与一处前端状态,不涉及接口/配置;
handler.go与 Cloud 一致,channel.go/ 关联页 / locale 在 Cloud 的差异不与本改动重叠,预计 sync 无冲突。Related Issues
无(来自外部用户反馈)。
依赖 felinics/ui#30(AutoHeight 在 KeepAlive 切回时不再从 0 重新增高)。等它合并后,本 PR 再 bump
packages/uigitlink;在此之前本 PR 暂不合并。Validation
go test ./internal/channel/inbound/... ./internal/command/... ./internal/i18n/... ./internal/handlers/...通过;pre-commit hook 的 golangci-lint + go test 通过。TestRequireWorkspaceExecUnboundIdentityPointsToLink:未关联身份走外部 Agent 门禁时回复包含/link与关联路径。TestExecute_WritePermissionDenied追加/link断言。vue-tsc因packages/ui的#/lib/utils解析失败报大量无关错误(改动文件 0 个),以本 PR 的 CI typecheck 为准。isLoading = asyncStatus === 'loading'推断)。Screenshots / Recordings
未上传截图:本地截图无法通过 CLI 作为 GitHub 附件上传。视觉变化仅为文案与「轮询时不再出现 spinner」,替代验证见 Validation 中的浏览器采样;人工 QA 时补充截图。
Human QA