Repository navigation
[AI Improvement] [Task] Remove dead container image cleanup cluster (cleanupBuildImages, ArtifactRegistryCleaner, ContainerRegistryCleaner) and artifactregistry.deletePackage - #11361
Draft
joehan wants to merge 1 commit into
Conversation
…artifactregistry.deletePackage (b/577232065)
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes unused container and artifact registry cleaning logic, including the cleanupBuildImages function, the ArtifactRegistryCleaner and ContainerRegistryCleaner classes, and the deletePackage API helper, along with their associated unit tests. I have no feedback to provide.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves Buganizer b/577232065
This PR removes dead container image cleanup code in
src/deploy/functions/containerCleaner.tsandsrc/gcp/artifactregistry.tsthat has had no production callers since #8324 and #8771:cleanupBuildImages: post-deploy image cleanup stopped in [BREAKING(functions)] Update post-deploy function logic to stop aggressively deleting conatiners #8324 and functions:delete cleanup removed in fix: remove container cleanup logic in functions:delete command #8771.ArtifactRegistryCleanerandContainerRegistryCleaner: only constructed insidecleanupBuildImagesand their tests.artifactregistry.deletePackage: only consumed byArtifactRegistryCleaner.cleanupFunction().colorette,artifactRegistryDomain,artifactregistry,backend,utils,poller) fromcontainerCleaner.tsandcontainerCleaner.spec.ts.firebase functions:deletegcfartifacts(listGcfPaths,deleteGcfArtifacts, andDockerHelper).Scenarios Tested
npm run build: built clean with 0 errors.npm run test:compile: compiled clean with 0 type errors.npm run lint:quiet: full repository ESLint and Prettier check passed with 0 errors.npx mocha src/deploy/functions/containerCleaner.spec.ts src/gcp/artifactregistry.spec.ts: all 21 tests passed.git grep -n -w -E "cleanupBuildImages|ArtifactRegistryCleaner|ContainerRegistryCleaner|deletePackage" -- .: returned 0 matches.Sample Commands
N/A (Internal dead code removal with no user-visible change)