Skip to content

[AI Improvement] [Task] Remove dead container image cleanup cluster (cleanupBuildImages, ArtifactRegistryCleaner, ContainerRegistryCleaner) and artifactregistry.deletePackage - #11361

Draft
joehan wants to merge 1 commit into
mainfrom
ai-improve-577232065-task-remove-dead-container-image-cl
Draft

joehan wants to merge 1 commit into
mainfrom
ai-improve-577232065-task-remove-dead-container-image-cl

Conversation

@joehan

@joehan joehan commented Oct 23, 2026

Copy link
Copy Markdown
Member

Description

Resolves Buganizer b/577232065

This PR removes dead container image cleanup code in src/deploy/functions/containerCleaner.ts and src/gcp/artifactregistry.ts that has had no production callers since #8324 and #8771:

Scenarios Tested

  • npm run build: built clean with 0 errors.
  • npm run test:compile: compiled clean with 0 type errors.
  • npm run lint:quiet: full repository ESLint and Prettier check passed with 0 errors.
  • npx mocha src/deploy/functions/containerCleaner.spec.ts src/gcp/artifactregistry.spec.ts: all 21 tests passed.
  • git grep -n -w -E "cleanupBuildImages|ArtifactRegistryCleaner|ContainerRegistryCleaner|deletePackage" -- .: returned 0 matches.

Sample Commands

N/A (Internal dead code removal with no user-visible change)

…artifactregistry.deletePackage (b/577232065)
@joehan joehan self-assigned this Oct 23, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes unused container and artifact registry cleaning logic, including the cleanupBuildImages function, the ArtifactRegistryCleaner and ContainerRegistryCleaner classes, and the deletePackage API helper, along with their associated unit tests. I have no feedback to provide.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant