Repository navigation
Conversation
Recipient rows are fixed 40px single-line fields, so a list longer than the field width can neither expand nor be reviewed before sending.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #141: To/Cc/Bcc were fixed-height (40px)
single-linefields, so once the recipient list exceeded the field width it could neither expand to another line nor be reviewed before sending. Recipient rows now wrap and grow (up to five lines, then clip), and the send path accepts newline-separated addresses, so wrapped/pasted lists parse instead of failing or — worse — passing validation as one glued address.Change
ui/components/composer-controls.slint—RecipientRowis now multi-line (single-line: false,wrap: word-wrap). Row height tracks an invisible wrapping twin (field-mirror, same origin/font/wrapping, 4px narrower so it never wraps less),min(132px, max(40px, …)),clip: true. Single-line rows render exactly 40px as before.ui/components/composer-fields.slint— Cc/Bcc rows stack below the To row's actual height (Cc/Bcc are now always-instantiated withvisibleinstead ofif, so their heights are always readable); the contact-suggestion popup anchors under the To row (to-row.height - 3px, identical 37px for single-line rows).src/mail.rs—parse_recipientsalso splits on\n(one-address-per-line pastes);parse_addressrejects surviving control characters (\r,\n) so multiline input can never smuggle a header break into an address.src/compose_controller.rs—compose_recipient_query/complete_compose_recipienttreat\nas a separator; completion after a newline-separated prefix normalizes to,instead of gluing onto the previous line.User-visible effects
Long To/Cc/Bcc lists wrap visibly and stay keyboard-navigable (arrows/Home/End across wrapped lines); Return still inserts a soft break inside the field, which now parses correctly at send. No change for short lists.
Tests
cargo/rustc, no display), against byte-verified copies ofmain(all four base blobs hash-matched before patching). Relying on CI (cargo fmt --check,clippy,cargo test,slint-viewer --check) as the gate — please tell me if the row heights need adjustment after a visual check, and I will iterate.edited/suggestions-openwiring, so contact autocomplete only ever fires for To. Happy to file or fix separately.Notes
AGPL-3.0-only, with no credentials, mailbox data, or personal fixture data included.