Repository navigation
Update fluxcd/pkg/git with symlink removal fix - #1118
Draft
stefanprodan wants to merge 2 commits into
Draft
stefanprodan wants to merge 2 commits into
stefanprodan wants to merge 2 commits into
Conversation
The temp dir on macOS is reached through a symlink, which BoundOS rejects for nested paths. Resolve it before binding the filesystem. Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
Switching to a push branch where a tracked symlink was removed or replaced deleted the link's target instead of the link, failing with "no such file or directory" or leaving the worktree without files that are still tracked, including .git/config. Add tests for switching branches over symlink changes. Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
stefanprodan
force-pushed
the
bump-pkg-git-symlinks
branch
from
October 28, 2026 09:10
3464236 to
638e519
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1037
Depends on fluxcd/pkg#1354.
Changes:
github.com/fluxcd/pkg/git.testutil.Cloneon macOS, where the temp dir is reached through a symlink.Supersedes #1077. Thanks to Jojin for the investigation.
The fix can be tested with
ghcr.io/fluxcd/image-automation-controller:rc-638e519a. This image requires Flux 2.10.