Repository navigation
fix(soldr): read passed steps from the porcelain log on schema-2 success - #9
Merged
Merged
Conversation
soldr 0.9.51's success line drops 'steps' (soldr#4010) but keeps
log_path, whose '# --- step NAME: CMD ---' headers name every step.
Verified against a real 'soldr lint rust --check' run: fmt and host
clippy are stamped and verify valid.
Ci-Attestation: {"at":1794186290,"gate":"python/all/fmt","host":"linux-x86_64","key":"751731a5434a571ab1fc085f911a91462d812a87fb834feccbcc09255f590121","lane":"lint","parents":["6d33991dbaa519ce8a62afb49adbcf2dd7c2cc2c"],"secs":4,"stamp":"e85a6c58e495f9e5d10819462f78f6aa","tree":"689a595e2e8309ae1fcd601a50a3a314949e22af","v":1,"via":"run"}
Ci-Attestation: {"at":1794186290,"gate":"python/all/lint","host":"linux-x86_64","key":"751731a5434a571ab1fc085f911a91462d812a87fb834feccbcc09255f590121","lane":"lint","parents":["6d33991dbaa519ce8a62afb49adbcf2dd7c2cc2c"],"secs":4,"stamp":"1098f70c66123b7a6eb12893450235b9","tree":"689a595e2e8309ae1fcd601a50a3a314949e22af","v":1,"via":"run"}
Ci-Attestation: {"at":1794186290,"gate":"python/all/types","host":"linux-x86_64","key":"751731a5434a571ab1fc085f911a91462d812a87fb834feccbcc09255f590121","lane":"lint","parents":["6d33991dbaa519ce8a62afb49adbcf2dd7c2cc2c"],"secs":4,"stamp":"42bbda297a2c410a5304abb147612f46","tree":"689a595e2e8309ae1fcd601a50a3a314949e22af","v":1,"via":"run"}
Ci-Attestation: {"at":1794186335,"gate":"python/linux-x64/test","host":"linux-x86_64","key":"1ba34e2c315bf4a6db2c5bb57cadbd33f7ea9fa36cc8e5e20521dd67185e67d7","lane":"tests","parents":["6d33991dbaa519ce8a62afb49adbcf2dd7c2cc2c"],"secs":44,"stamp":"42cc59de879b34f528b4d0cba86ffc96","tree":"689a595e2e8309ae1fcd601a50a3a314949e22af","v":1,"via":"run"}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Real-world check of #8 against
soldr 0.9.51: a successfulSOLDR_PORCELAIN=1 soldr lint rust --checkprints{"status":"ok","exit_code":0,"log_path":...}with nosteps(schema 2, soldr#4010), so the adapter stamped nothing. It now reads the step names from the# --- step NAME: CMD ---headers inlog_path.Verified on a scratch crate:
prooft soldrstampsrust/all/fmt+rust/x86_64-unknown-linux-gnu/clippy, andprooft verifyreports both valid.Retrospective item 10 (soldr: keep step names on the success line). Head is attested; no trust surface touched.