Repository navigation
Stream data and list topics for a session without a time range - #207
Merged
Merged
Conversation
`download_data`, `iter_messages`, and `get_topics` no longer require `start` and `end` when querying by session, matching the API, which needs a time range only when querying by device. A range is still required with `device_id` or `device_name`. `get_topics(include_schemas=True)` now returns `None` for a topic's `schema` when the API omits it instead of raising. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012yf4xszPJuZbmsVHpZeUGr
![foxglove-beefcake[bot]](https://avatars.githubusercontent.com/in/5305709?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012yf4xszPJuZbmsVHpZeUGr
mguida22
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
Streaming data and listing topics by session no longer require a time range, and topics without a schema no longer raise an error.
Docs
None
Description
The v1 API needs
startandendon/data/streamonly when querying by device; a session, recording or episode identifies the data on its own./data/topicsdoesn't say either way, and the API applies the same device-only rule. The client required a range for session queries too.download_data,iter_messagesandget_topicsnow requirestartandendonly withdevice_idordevice_name.get_topics(include_schemas=True)returns"schema": Nonefor a topic the API sends without a schema, which the spec allows, instead of raising.Compatibility: the range error message changed, from "unless using episode_id, recording_id, or recording_key" to "when using device_id or device_name". Calls that used to succeed behave the same.
Validated with black, flake8, pyright, and pytest on Python 3.8: 206 passed. The new and updated tests are in
tests/test_client.py,tests/test_data.pyandtests/test_episodes.py. The ROS and stream-message tests can't install their dependencies in my environment, so CI covers those.client.get_topics(session_id="ses_1")raisedRuntimeError: start and end must be provided unless using episode_id, recording_id, or recording_key.It returns the session's topics.
Generated by Claude Code