Repository navigation
admin: set favorites as default Qubes menu - #1978
Conversation
67ed65e to
bdc0a9f
Compare
legoktm
left a comment
There was a problem hiding this comment.
Previously the menu-favorites were incorrectly set in dom0, so this properly sets them by the Qube that owns them, and fixes the keepassxc to be from admin-vault.
I don't think this was incorrect? I think we specifically want people to go through the dom0 .desktop files because that runs through the launcher/updater whereas the direct VM entries won't do that.
95dc60a to
4e79731
Compare
|
@legoktm right, thank you! sorry I totally forgot the context there. reverted that change, but the favorites menu setting is now ready for a pass! |
legoktm
left a comment
There was a problem hiding this comment.
Works great; two comments about improving uninstall + tests but that can be done in follow-ups.
| def revert_admin_dom0_menu() -> None: | ||
| """ | ||
| Undo the dom0 app menu settings applied by admin_salt.sd-admin, leaving | ||
| alone any that have since been changed to something else. |
There was a problem hiding this comment.
I don't think we really need to worry about this, just because on each dom0 salt run (updater), it's going to override any user customized changes anyways. So I think we could just unconditionally unset these.
Since this is just for uninstall code I'll leave it for a follow-up.
| favorites = all_vms["dom0"].features.get("menu-favorites", "") | ||
| assert favorites == manage.ADMIN_DOM0_MENU_FEATURES["menu-favorites"] | ||
| # No favorites on the qubes themselves, which would bypass sdw-updater | ||
| for vm in ("sd-admin", "sd-admin-vault"): |
There was a problem hiding this comment.
nice, maybe this should be for all VMs?
Sets favorites as the defaults Qubes menu option.
Also fixes the keepassxc entry, adds an uninstall utility to revert the settings, and adds some tests.
Refs #1805
Test plan
make dev-adminfrom the branch and verify thatChecklist
This change accounts for:
rpm-build/SPECS/securedrop-workstation-dom0-config.spec)