Skip to content

securedrop-manage: rename --configure to import --from-tails - #1984

Open
vickiniu wants to merge 1 commit into
mainfrom
vicki/tails-import
Open

vickiniu wants to merge 1 commit into
mainfrom
vicki/tails-import

Conversation

@vickiniu

@vickiniu vickiniu commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #1950

Test plan

  • Running securedrop-manage --configure should reject, and the securedrop-manage should show import subcommand help text
  • With Tails Journalist workstation, securedrop-manage import --from-tails --target journalist imports Tails journalist config
  • With Tails Admin workstation USB, securedrop-manage import --from-tails --target admin imports Tails admin config

Checklist

This change accounts for:

  • any necessary RPM packaging updates (e.g., added/removed files, see rpm-build/SPECS/securedrop-workstation-dom0-config.spec)
  • any required documentation

@vickiniu vickiniu moved this to In Progress in SecureDrop Nov 16, 2026
@vickiniu
vickiniu marked this pull request as ready for review November 16, 2026 16:41
@vickiniu
vickiniu requested a review from a team as a code owner November 16, 2026 16:41
@vickiniu vickiniu moved this from In Progress to Ready For Review in SecureDrop Nov 16, 2026
@legoktm

legoktm commented Nov 16, 2026

Copy link
Copy Markdown
Member

@nathandyer @ChumOfChance (at your convenience) could you review the CLI syntax in the test plan and 👍🏾 if it looks good to you?

@ChumOfChance

Copy link
Copy Markdown
Contributor

@vickiniu securedrop-manage import --from-tails --target journalist behaviour is the same as the old-old sdw-admin --configure? If so, I think this is good. 👍

@vickiniu

Copy link
Copy Markdown
Contributor Author

@ChumOfChance yes, exactly!

so sdw-admin --configure and securedrop-manage configure --target journalist are now: securedrop-manage import --from-tails --target journalist

the newly-added securedrop-manage configure --target admin is now securedrop-manage import --from-tails --target admin

@legoktm legoktm added the 4.3-openqa-all Run on OpenQA in Qubes 4.3 deploying the journalist workstation combined with the admin workstation label Nov 17, 2026
@legoktm

legoktm commented Nov 17, 2026

Copy link
Copy Markdown
Member

Should it be e.g. --from=tails? so then later we have --from=backup instead of adding more flags?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4.3-openqa-all Run on OpenQA in Qubes 4.3 deploying the journalist workstation combined with the admin workstation

Projects

Status: Ready For Review

Development

Successfully merging this pull request may close these issues.

Change --configure to --tails-import

3 participants