[sylvesterkaczmarek]

Fixes #49.

Compare concrete version types and flattened data instead of hashes. Distinct versions remain separate when hashes collide, and comparisons with unrelated objects return NotImplemented.

Adds regression coverage for collisions, unhashable objects, different version types, private attributes and custom flattening.

Validation:

• TZ=UTC python -m unittest discover .: 269 tests passed, including Docker wrappers.
• python -m mypy concoursetools: passed.
• Pre-commit checks on both changed files: passed.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[sylvesterkaczmarek]

Revalidated #50 with the full project checks: 269 unit tests pass under TZ=UTC, mypy reports no issues across 17 source files, the complete pre-commit stack passes, and a clean Sphinx HTML build succeeds. I also ran the new equality tests against unchanged upstream main; they reproduce the defect with four failures and two errors, including hash-collision equality and comparisons with unhashable unrelated objects.

The source tree is unchanged; I refreshed the commit as SSH-verified 4cddf5f. The PR is 0 behind and mergeable, and the existing Sonar quality gate is passing. The three fork-triggered Actions workflows are currently action_required pending maintainer approval. Ready for review.

[sylvesterkaczmarek]

Hi maintainers, following up on this PR as it hasn’t had a maintainer review yet. The implementation and local validation are documented above, while the hosted workflows are still waiting for maintainer approval. Could someone approve the workflows and review the PR when convenient? Happy to address any feedback.

[sylvesterkaczmarek]

Could someone review the hash-collision equality fix when convenient? The workflows still need maintainer approval.

[gchqdev227]

Hi @sylvesterkaczmarek, thank you for your contribution.

Unfortunately this repository currently only accepts pull requests from organisation members or approved outside collaborators.

Thank you for bringing this bug to our attention.