Repository navigation
Conversation
|
Apologies but we are unable to accept this due to the name of the operation / underlying encryption standard not being corporately acceptable. |
|
Hi @GCHQDeveloper581, thank you for the feedback. I completely understand the corporate policy limitations regarding the name. If I rename the operation and all related files to something like "From Esoteric JS", while keeping the exact same decoding logic, would you be open to reopening and merging this PR? Let me know what name works best for your corporate standards, and I will gladly update the commits. |
|
In principle, yes. It would have to depend on how sanitised you could make it. The biggest problem I can envisage is that the wikipedia link itself contains the 'non-corporate' word. Also a question of "how would people who had a use case find the correct operation" |
|
@GCHQDeveloper581 I renamed the operation to "From JS6Chars" and pushed to this branch. Removed every reference to the old name and dropped the Wikipedia infoURL since the link itself had the flagged term. Description now explains the mechanism in plain terms (6 characters: [ ] ( ) ! +), which should also help with discoverability. |
|
I think it's best if you rename the branch, squash the commits, and start a new PR. I haven't reviewed it line by line, but at first sight it's looking good (and addresses my original concerns). |
|
@GCHQDeveloper581 Opened the new PR with a single squashed commit as requested: #2681 |
Adds a new operation to decode JSFuck encoded JavaScript.
JSFuck is an esoteric programming style that uses only 6 characters: [ ] ( ) ! +
Closes #1054
Changes:
src/core/operations/FromJSFuck.mjsCode tidycategory inCategories.jsontests/operations/tests/FromJSFuck.mjs