Repository navigation
feat(apps): the chain proposes, curation corrects - #309
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem
/appswas a curated list of ten entries against two hundred and ten realms,whose only contribution workflow was to stare at a JSON file. An earlier attempt
in this branch rendered the community's list faithfully beside it, which turned
out to be the wrong thing to be faithful to: six screens of link list in which
the actual apps were indistinguishable from a language server and a 2023
conference talk.
What this is now
The chain proposes and curation corrects.
Discovery. Every realm people actually call is ranked, and the whole tuning
surface is two constants:
Distinct callers outrank raw calls tenfold because they answer different
questions. Calls measure activity, and activity is trivially manufactured: one
script in a loop is thousands of calls and one caller. Callers measure reach,
and buying that costs a funded address per unit.
TestDiscoverRanksReachOverActivitypins it with exactly that pair.
Every default is somebody's own word. The description is the realm's own
package doc comment, first sentence. It was already extracted for the docs tab
and thrown away; this stores it in
symbol_index.package_doc. The picture is acapture of the app's website, falling back to the realm. Neither is this repo
inventing a sentence about somebody else's code, which is the only thing that
makes auto-listing defensible.
Three levers, and no large one.
apps.json, awesome-gnoapps.jsonsupersedesmoderation.tomlThe website leads and the realm is second. Somebody sent here wants the
thing itself; the realm page is what they want next, and only if they are the
kind of person who wants it.
The ask moved to the footer. Three small links under the grid. Asking a
visitor for a pull request before they have seen anything is asking a favour of
someone who does not yet know what this is.
Corrections made to this branch's own earlier work
Ranking a listed entry to the top was wrong. It put Boards2, which nobody
had called, above the busiest realm on the chain. Being listed means included
despite having no metrics; it does not mean important. A listed entry is now
floored at
scoreVouchedrather than promoted, so a realm people genuinely usestill wins and an off-chain app still clears the last realm with two calls.
A curated entry with no traffic vanished. Somebody writes a sentence and the
page it was written for drops it. Being in
apps.jsonis now itself the vouch,and the separate
pinflag it needed is gone.A monorepo's homepage is not its contents'. gnodev, gnobro and gnoclient are
linked as
gnolang/gno/tree/master/..., and that repo declaresgno.land, sothe first run gave three CLI tools a picture of the chain's website and of each
other. Only repository roots are followed.
The screenshot gate refused curated websites. Kourt's site is in
apps.json,not in awesome-gno, so its card asked for a picture and got a 400 with nothing
in any log to say why. The allowlist now spans both sources; it is still an
exact-string match, so another page on a listed app's own domain is refused.
Two things worth reviewing closely
The skip list is served, not merely applied. A page that quietly dropped an
entry is indistinguishable from one that lost it, and an unexplained removal is
indistinguishable from censorship.
moderationcomes back in the response withevery reason, the page prints them, and validation refuses a skip with no
why.The file ships empty on purpose: the first entry should be one somebody can
point at.
Each field says where it came from, as one quiet mark on the card: curated,
community, chain, or nobody-yet. A reader who cannot tell a vouched-for sentence
from a generated one has to trust both equally or neither. The
checkeddatethe registry requires moved into that mark's tooltip rather than ceasing to
exist when the dense table went.
Also in here
Depends on gnoverse/gnoshot#1, merged and deployed: gnoshot classified every
non-gnoweb page as an error page and served a placeholder, and its font-ready
wait photographed client-rendered apps mid-spinner (gnoswap.io came out a
228-byte blank).
While rewriting the page block I swallowed the developer section and the network
switcher, which had landed in that range on main. Recovered, and the
duplicate-declaration guard in
pkg/webcaught the leftover.Verification
go test ./...,gofmt -l .,go vet ./...clean. Browser suite 318 passed,1 failed:
realm-graph-views.spec.js:102, which passes in isolation and isuntouched by this change.
make screenshotsrefreshesappsandapps-network.