Repository navigation
Conversation
Premultiply node-circle RGB by the final alpha after circle coverage is applied. Route emitRGB and emitDefault through emitRGBA so all output helpers apply opacity consistently. Unpremultiply the shared CPU-side segment color before uploading it to skeleton shaders, then premultiply once at emission in perspective views. Preserve straight-alpha output in slice views.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1148 fixed emitRGBA but I ignored emitRGB and emitDefault
For this PR I fixed the issue with uColor already being premultiplied causing the segment to appear darker than it should. I didn't fix this originally because the segment color PR fixes it separately.