Repository navigation
Conversation
inhere
added a commit
that referenced
this pull request
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A single
required_ifliteral misses dependencies whose Go type is a defined scalar. For example,type Status stringwithStatus("member")allows an empty field underrequired_if:Mode,member, while the equivalent built-in string correctly requires it.Reuse
IsEqualafter the existing literal conversion succeeds. This keeps the existing conversion and empty-value rules and aligns the single-literal path with the value comparison already used elsewhere.Validated against current master
b148b170on Go 1.26.0 / macOS arm64:Other supported runtime/OS combinations and hosted CI remain unverified locally.