Repository navigation
fix(validate): handle nil containment inputs - #356
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Contains(nil, "x")andNotContains(nil, "x")panic becauseincludeElementcallsType()on an invalid reflected value before installing its recovery handler. Other unsupported container types already return false for both validators.Check for an invalid reflected container first and return the existing unsupported-input result. Add coverage for nil input, unsupported scalars, typed nil slices/maps, matching/missing elements, nil elements and substrings.
Testing
Validation with Go 1.26.10:
go test -race ./...,go vet ./...andgo build ./...passed. The regression panics before the fix. Strict golangci-lint 2.15.0 reports the same 66 existing findings on the base and fixed versions, with no new findings.Manual check: both containment validators should return false for a nil container without panicking; a typed nil slice remains a valid empty container, so
NotContains([]string(nil), "x")should return true.Prepared with Codex assistance for reproduction, implementation and tests.
Breaking Changes
None.