Repository navigation
jsonnet: add common and per component settings for annotations - #17143
Merged
Merged
Conversation
56quarters
force-pushed
the
56quarters/annotations
branch
3 times, most recently
from
November 2, 2026 20:33
51c23e2 to
910ca9d
Compare
56quarters
marked this pull request as ready for review
November 2, 2026 21:07
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
56quarters
marked this pull request as draft
November 2, 2026 21:17
56quarters
force-pushed
the
56quarters/annotations
branch
from
November 3, 2026 00:48
910ca9d to
def1744
Compare
Add common and per-component configuration to allow key-value pairs to be set as annotations on each Mimir component. The goal is to allow us to easily turn on various types of profiling at a per-component granularity via annotations.
56quarters
force-pushed
the
56quarters/annotations
branch
from
November 3, 2026 00:50
def1744 to
9693ce1
Compare
Contributor
Author
|
@cursor review |
Contributor
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 9693ce1. Configure here.
56quarters
marked this pull request as ready for review
November 3, 2026 14:06
Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
tcard
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Add common and per-component configuration to allow key-value pairs to be set as annotations on each Mimir component. The goal is to allow us to easily turn on various types of profiling at a per-component granularity via annotations.
Which issue(s) this PR fixes or relates to
N/A
Note to reviewers
There are places in our existing jsonnet that could use this. I'll update those in a follow-up PR.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]. If changelog entry is not needed, please add thechangelog-not-neededlabel to the PR.about-versioning.mdupdated with experimental features.