Repository navigation
change:optimize iCalendar recurrence evaluation with guarded seeking - #145
Merged
Merged
Conversation
Skip historical occurrences for eligible UTC rules and plain non-UTC subdaily rules with INTERVAL=1. Preserve DTSTART, recurrence phase, and next/previous behavior. Keep the original iterator when seeking fails or validation rejects the candidate. Require libical >= 3.0.11.
greenbonebot
enabled auto-merge (rebase)
October 26, 2026 12:54
timopollmeier
previously approved these changes
Oct 27, 2026
timopollmeier
disabled auto-merge
October 27, 2026 10:18
Extract the guarded seek logic to simplify recurrence evaluation and fix indentation without changing scheduling behavior.
greenbonebot
enabled auto-merge (rebase)
October 27, 2026 10:43
timopollmeier
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Optimize iCalendar recurrence evaluation using guarded libical seeking. Preserve existing scheduling behavior and fall back to historical iteration when seeking is unsafe. Require libical ≥ 3.0.11.
Verified with existing utility tests and comparisons against the original recurrence calculation.
Why
Frequent schedules with old start dates can require millions of iterations, causing excessive CPU usage and potential denial of service. This reduces unnecessary historical iteration for supported rules.
References
GEA-2164
Checklist