Repository navigation
Conversation
Contributor
|
@alrikkk is attempting to deploy a commit to the Hack Club Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
you may close this pr if its irrelevant |
Member
|
hmm the login button feels kinda cluttered for the already stacked navbar, i would think there is a better way of handling this... |
Author
|
Can I have another shot at this ?? |
Member
|
Yeah sure! Open a new PR :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey!
I noticed that returning Hack Club members could end up going through the new-member onboarding flow when clicking Join and entering their email , the welcome to hackclub..... all the way to ready to start. It wasn't clear where existing members should go to log in. IDK if this was only for me but i did a little digging and found this repo and tried to fix it. ( hopefully i did )
This PR adds a separate Login link to the desktop and mobile navigation so returning members can access the existing login page directly.
A couple of other things included:
A note on the original issue: This doesn't add automatic detection of existing members in the Join flow. It simply provides a separate login entry point while keeping the existing onboarding flow unchanged.
Testing
bun test— 176 tests had passed.bun run lint— this one passed with no warnings or errors.app/[locale]/clubs/page.module.css, which I hadn't modified.Thanks for taking a look! :)