Skip to content

Added login link and fix uth email encoding - #2293

Closed
alrikkk wants to merge 1 commit into
hackclub:mainfrom
alrikkk:mbappe_special
Closed

alrikkk wants to merge 1 commit into
hackclub:mainfrom
alrikkk:mbappe_special

Conversation

@alrikkk

@alrikkk alrikkk commented Nov 4, 2026

Copy link
Copy Markdown

Hey!

I noticed that returning Hack Club members could end up going through the new-member onboarding flow when clicking Join and entering their email , the welcome to hackclub..... all the way to ready to start. It wasn't clear where existing members should go to log in. IDK if this was only for me but i did a little digging and found this repo and tried to fix it. ( hopefully i did )

This PR adds a separate Login link to the desktop and mobile navigation so returning members can access the existing login page directly.

A couple of other things included:

  • Fixed double URL encoding in the email parameter passed to the Slack onboarding page.
  • Added Login translations for all 8 supported languages.
  • Added tests for email encoding, whitespace trimming, plus-addressed emails, and empty email values.

A note on the original issue: This doesn't add automatic detection of existing members in the Join flow. It simply provides a separate login entry point while keeping the existing onboarding flow unchanged.

Testing

  • bun test — 176 tests had passed.
  • bun run lint — this one passed with no warnings or errors.
  • The production build couldn't be verified locally. The default Turbopack build encountered an internal worker-process error, while the Webpack build encountered a CSS Modules selector error in app/[locale]/clubs/page.module.css, which I hadn't modified.

Thanks for taking a look! :)

@alrikkk
alrikkk requested a review from a team as a code owner November 4, 2026 17:51
@vercel

vercel Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

@alrikkk is attempting to deploy a commit to the Hack Club Team on Vercel.

A member of the Team first needs to authorize it.

@alrikkk

alrikkk commented Nov 5, 2026

Copy link
Copy Markdown
Author

you may close this pr if its irrelevant

@3kh0

3kh0 commented Nov 6, 2026

Copy link
Copy Markdown
Member

hmm the login button feels kinda cluttered for the already stacked navbar, i would think there is a better way of handling this...

@3kh0 3kh0 closed this Nov 6, 2026
@alrikkk

alrikkk commented Nov 6, 2026

Copy link
Copy Markdown
Author

Can I have another shot at this ??

@3kh0

3kh0 commented Nov 6, 2026

Copy link
Copy Markdown
Member

Yeah sure! Open a new PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants