Skip to content

Refactor Thymeleaf dependencies to resolve potential memory leak - #7914

Merged
f2c-ci-robot[bot] merged 2 commits into
mainfrom
bug/thymeleaf-might-cause-memory-leak
Nov 6, 2025
Merged

Refactor Thymeleaf dependencies to resolve potential memory leak#7914
f2c-ci-robot[bot] merged 2 commits into
mainfrom
bug/thymeleaf-might-cause-memory-leak

Conversation

@JohnNiang

@JohnNiang JohnNiang commented Nov 6, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

What type of PR is this?

/kind bug
/area core
/milestone 2.22.x

What this PR does / why we need it:

Supersedes #7678.

See halo-dev/thymeleaf#4 for more.

Does this PR introduce a user-facing change?

修复潜在的内存泄漏问题

@f2c-ci-robot f2c-ci-robot Bot added the kind/bug Categorizes issue or PR as related to a bug. label Nov 6, 2025
@f2c-ci-robot f2c-ci-robot Bot added this to the 2.22.x milestone Nov 6, 2025
@f2c-ci-robot f2c-ci-robot Bot added area/core Issues or PRs related to the Halo Core do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 6, 2025
ruibaby
ruibaby approved these changes Nov 6, 2025
View reviewed changes

@ruibaby ruibaby left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot Bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 6, 2025
@ruibaby

ruibaby commented Nov 6, 2025

Copy link
Copy Markdown
Member

/hold

@f2c-ci-robot f2c-ci-robot Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 6, 2025
@ruibaby

ruibaby commented Nov 6, 2025

Copy link
Copy Markdown
Member

https://github.com/halo-dev/halo/actions/runs/19129978229/job/54668145618?pr=7914

@JohnNiang

JohnNiang commented Nov 6, 2025

Copy link
Copy Markdown
Member Author

https://github.com/halo-dev/halo/actions/runs/19129978229/job/54668145618?pr=7914

Please wait for #7916 to be merged.

@f2c-ci-robot f2c-ci-robot Bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 6, 2025
@sonarqubecloud

sonarqubecloud Bot commented Nov 6, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

ruibaby
ruibaby approved these changes Nov 6, 2025
View reviewed changes

@ruibaby ruibaby left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 6, 2025
@f2c-ci-robot

f2c-ci-robot Bot commented Nov 6, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ruibaby

ruibaby commented Nov 6, 2025

Copy link
Copy Markdown
Member

/unhold

@f2c-ci-robot f2c-ci-robot Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 6, 2025
@f2c-ci-robot
f2c-ci-robot Bot merged commit 71c621b into main Nov 6, 2025
10 checks passed
@JohnNiang
JohnNiang deleted the bug/thymeleaf-might-cause-memory-leak branch November 6, 2025 13:43
@JohnNiang

JohnNiang commented Nov 6, 2025

Copy link
Copy Markdown
Member Author

/cherrypick release-2.21

@halo-dev-bot

halo-dev-bot commented Nov 6, 2025

Copy link
Copy Markdown
Contributor

@JohnNiang: new pull request created: #7917

Details

In response to this:

/cherrypick release-2.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@halo-dev-bot halo-dev-bot mentioned this pull request Nov 6, 2025
Merged
f2c-ci-robot Bot pushed a commit that referenced this pull request Nov 6, 2025
@halo-dev-bot
[release-2.21] Refactor Thymeleaf dependencies to resolve potential m…
292d124 
…emory leak (#7917)

This is an automated cherry-pick of #7914

/assign JohnNiang

```release-note
修复潜在的内存泄漏问题
```
@ruibaby ruibaby removed this from the 2.22.x milestone Nov 16, 2025
@ruibaby ruibaby added this to the 2.22.0 milestone Nov 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ruibaby ruibaby ruibaby approved these changes

Assignees

@ruibaby ruibaby

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.

Projects

None yet

Milestone

2.22.0

Development

Successfully merging this pull request may close these issues.

3 participants

@JohnNiang @ruibaby @halo-dev-bot