Repository navigation
Setup: GitHub is connected as Projects reads it, and Disconnect lets go of the reader's own link (0.3.10) - #21
Merged
Conversation
…go of the reader's own link (0.3.10) Quick setup said "1. Connect GitHub" while Projects said "GitHub connected as @login". Setup read a `connectors` list from GET /v1/connection, which has answered `connections` since the cloud's views were folded together, so that half of its reading was dead; and it never counted the reader's own link (`github-user`), which Projects counts. `linked` reads both answers: GitHub is the org's App (GET /v1/provider) or the reader's own link. With both answered it follows them both ways, so a Disconnect on Projects reads in Setup; a half answer only ever adds it. Disconnect lets go of the reader's own link first (`leaving`), else the org's App accounts, an org admin's.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On hanzo.ai, Quick setup said 1. Connect GitHub (0/3) while Projects said GitHub connected as @Darkhorse7stars for the same person.
Why
connectorslist fromGET /v1/connection. The cloud has answeredconnectionssince its views were folded together (hanzo-inc/cloud 15ada8cfb), so that read found nothing.github-user), which Projects counts.Change (
pkg/app/src/Setup.tsx)linked(providers, connections): GitHub is the org's App (GET /v1/provider) or the person's own link. With both answers in, GitHub follows them both ways, so a Disconnect on Projects shows in Quick setup too. A partial answer can only mark GitHub connected, never disconnected.POST /v1/provider/github/user/disconnect), else the org's App accounts (POST /v1/provider/github/disconnect, org admin only). The "only an admin" message applies to the org case only.@hanzo/app0.3.10, plus anLLM.mdnote.Tests
Setup.test.tsxcovers the shapes hanzo.ai answered for this account, the org App case, nothing connected, partial answers, that aconnectorslist is not read, Google addresses, and both Disconnect routes.Not in this PR:
Directory.tsx:276andbots/api.ts:192read the same staleconnectorskey.