Repository navigation
Setup: GitHub changes on Projects and in Quick setup read in the other without a reload (0.3.11) - #22
Merged
Merged
Conversation
…etup's reads there (0.3.11) Setup read GitHub on mount, on focus and after its own act, so a connect finished on Projects (after Setup had read) left it saying "Connect GitHub", and its own Disconnect left Projects saying "connected". A GitHub change is said on the window as `hanzo:github` (GITHUB_CHANGED), the name @hanzo/build's Projects and Settings say and hear. Setup says it after its Disconnect and its GitHub popup, and reads again on hearing it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On hanzo.ai, Quick setup (this package's
Setup) and the Projects banner (@hanzo/build) only agree after a reload:Change
A GitHub change is said on the window as
hanzo:github(GITHUB_CHANGED), the same name@hanzo/build's Projects and Settings now say and hear (hanzoai/build#6):LLM.mdnotes the event.Version 0.3.11.
Tests
Setup.test.tsxnow runs in happy-dom, so two new tests can mount Setup and run its effects:hanzo:githubevent makes Setup read/v1/connectionagain;/v1/provider/github/user/disconnectand sayshanzo:github, and Setup reads again.The existing static-markup tests are unchanged.