Repository navigation
palette: ⌘K leaves a press the page already answered - #23
Open
Darkhorse7stars wants to merge 1 commit into
Open
Darkhorse7stars wants to merge 1 commit into
Darkhorse7stars wants to merge 1 commit into
Conversation
Dev's composer (@hanzo/ui) opens its own commands on Ctrl+K and claims the press with preventDefault. summons opened the palette over them anyway, from App's and Shell's window listeners, so one press opened two lists: what was typed next went to "Search or jump to…", whose last row is Log out, and a click meant for the composer's commands signed the person out. summons now reads defaultPrevented: a press something on the page answered is not the palette's. A field that answers nothing still opens it, as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On hanzo.ai/dev, Ctrl+K in New run's text box opens the composer's own Commands list (Run, … Use a git URL), and the composer claims the press with
preventDefault.summons(pkg/app/src/seek.ts) opened the palette on top of it anyway, from both window listeners (App,Shell). So one press opened two lists, and what was typed next went to Search or jump to…, whose last row is Log out. A click aimed at the composer's commands signed the person out.seek.ts:summonsreadsdefaultPrevented, so a press something on the page already answered isn't the palette's. A field that answers nothing still opens it, as before.chord.ts:PresscarriesdefaultPrevented?.seek.test.ts: a claimed press doesn't summon, from a field or anywhere else.hanzo.ai pins @hanzo/app 0.2.63, so it'll carry the same change in its existing 0.2.63 patch until the pin moves.