Repository navigation
Conversation
Rememberable only coerced String timestamps, while Timeoutable already handles Integer last_request_at values. Cookie/session JSON can revive the remember timestamp as Integer, Float, or an integer-only string, so remember_me? failed even though the token was still valid. Coerce those forms with Time.at, matching Timeoutable.
Author
|
Hi! This is my first PR here, so the CI workflows are waiting for approval. Could a maintainer approve the run when you have a moment? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rememberable only coerced String timestamps in
remember_me?, while the Timeoutable hook already handles Integerlast_request_atvalues. Cookie/session JSON can revive the remember timestamp as an Integer, a Float, or an integer-only numeric string, so a still-valid remember cookie was rejected.This coerces Integer/Float with
Time.at(same idea as Timeoutable) and accepts integer-only numeric strings intime_from_json.Test plan
bundle exec ruby -Itest test/models/rememberable_test.rb→ 23 runs, 0 failures