Repository navigation
Conversation
repstein2
marked this pull request as ready for review
November 7, 2026 23:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a single-member-to-member sFlow RRD does not exist yet, the backend returns an empty PNG response and browsers show a broken-image icon. This is common for newly connected or low-volume members. Observed on 7.4.1.
This fix distinguishes absent local RRDs and remote HTTP 404s from other file or transport failures. Single-P2P PNG requests render “No Measurable Traffic” for missing data, and “Graph Temporarily Unavailable” for other FileError failures, which also log an operational warning. The subtitle is “No sampled traffic data is available between these members.” Existing graphs, including valid zero/flat graphs, retain normal rendering. No synthetic counters or RRDs are created.
PNG assets are served through the existing graph endpoint, authorization checks, and cache. Multi-P2P rendering and JSON/log/RRD exports keep their existing behavior. PHP 8.4 response-header helpers distinguish HTTP errors from transport failures.
Validation:
A missing file is not proof of a healthy collector: a bad root URL or absent mount can also leave files missing. Independent collector/root monitoring is still necessary. Error placeholders are valid images, so transport-status-only monitoring will not detect the rendered operational error.
Deployed as a pilot at Community IX NoVA. Ready for maintainer review; happy to adapt the presentation or test organization. The contributor emailed their signed CLA and public key to operations@inex.ie on November 7, 2026; INEX acknowledgement is pending.