Repository navigation
fix: close public user creation endpoints - #236
Merged
Merged
Conversation
- remove POST /users and POST /v2/users (unauthenticated) - drop disposable-email check and dependency - e2e: create users via createTestUser
sg-gs
approved these changes
Nov 9, 2026
| } | ||
|
|
||
| const emailDomain = emailMatch[2]; | ||
| const allowedEmail = disposable.validate(emailDomain); |
Member
There was a problem hiding this comment.
This is a filter for spammy emails, why do you remove it?
Member
Author
There was a problem hiding this comment.
@sg-gs it wasn't working in prod, so instead of keeping a useless lib that adds tech debt every time axios has a vulnerability, I removed it.
I could've added a dependency-free library that actually works, but suddenly enabling a filter that hasn't worked in prod for a long time could start blocking signups that work today. This check could fit better in drive-server, where we have more control and visibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
POST /usersandPOST /v2/usersdisposable-emailcreateTestUserWhy
internxt/disposableneeds manual updates and brings axios vulnerabilities.