Repository navigation
Conversation
Symfony 8.2 is not released yet, so the components come from 8.2.x-dev. - symfony/tui 8.2 adds TerminalInterface::getEventDispatcher(), now implemented by OutputTerminal - The event dispatcher of the container is compiled, so the listeners of the castor files go to a ScopedEventDispatcher - AsOption::$mode is typed as an InputOption mask, as Symfony Console does - The bash completion script of Symfony Console changed, and its snapshot with it
… number of the signal on its own
… input, output and error of Castor
…upted by one, like a shell
…AL_STDIO_INSTEAD_OF_PTY=1, to try it out
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move to Symfony 8.2, and use it to run a process on the standard streams of Castor.
Not mergeable before Symfony 8.2 is released (end of November): it relies on
8.2.x-dev(minimum-stability: dev), and drops Symfony 8.1.context()->withStdioInherited()runs the process like a line of a shell script, withProcess::inheritStdio()([Process] AddProcess::inheritStdio()to run a process with the standard streams of the current process symfony/symfony#66949): the real terminal and its size, the redirections of Castor, no/dev/ttyneeded, and aCTRL+Cthat Castor survives like a shell. Opt-in for now, sincegetOutput()is then empty: it could become the default in 2.0, likeCASTOR_USE_CHDIR.InterruptionListeneris removed: Console 8.2 exits with 128 + the signal number on its own ([Console] Exit with 128 + the signal number when a signal stops the application symfony/symfony#66950).ScopedEventDispatcher: the dispatcher of the container is compiled in 8.2, and callingaddListener()on it is deprecated.Closes #907