Repository navigation
Document claims validation performed by JwtParser.parse - #1082
Open
kimseongchan0914 wants to merge 1 commit into
Open
kimseongchan0914 wants to merge 1 commit into
kimseongchan0914 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1070
Summary
The
JwtParser.parseJavadoc only mentionedExpiredJwtException, whileDefaultJwtParseralso rejects tokens whosenbfis in the future. This PR documents the claims validation that actually happens during parsing:parse(CharSequence)describing:exp→ExpiredJwtException, subject to the configured clock and clock skewnbf→PrematureJwtException, subject to the configured clock and clock skewrequire*claims →MissingClaimException/IncorrectClaimExceptioniatis not validated against the current time. The issue mentionsiat, butDefaultJwtParseronly checksexpandnbf.@throws PrematureJwtExceptiontoparse(CharSequence),parse(CharSequence, JwtHandler)andparseClaimsJws(CharSequence), next to the existing@throws ExpiredJwtExceptiontags.This is a Javadoc-only change; behavior is unchanged.
Testing
./mvnw -pl api javadoc:javadocbuilds without errors.🤖 Generated with Claude Code