Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TrajectoryManager::update_anchor()indexesodom_stamps[idx]immediately afterlower_bound(). When the anchor timestamp is newer than the newest cached odometry, the search returnsend(), soidx == odom_stamps.size()and this reads out of bounds. The same problem occurs on a freshly constructed manager when its only timestamp is the initial zero entry.For example,
add_odom(1.0, Identity()); update_anchor(2.0, Identity());triggers a checked-vector assertion in the current implementation. Without checked access this is undefined behavior; an anchor just beyond the newest timestamp also changed the transform incorrectly in my optimized local build.Return before indexing when the search reaches
end(). This preserves the current odometry-to-world transform and cached interpolation samples when there is no odometry coverage. No extrapolation or automatic queuing is added; callers can submit the anchor again after more odometry arrives. Exact endpoint updates, translation interpolation, quaternion interpolation and the existing pruning behavior are retained.Adds eight regression cases using the actual trajectory implementation, covering:
odom2world()overloads with nontrivial rotations and translations.tests/is a standalone Eigen-only CMake project, so these utility tests need no ROS, CUDA, GTSAM or viewer dependencies. A separate Ubuntu GCC/Clang workflow runs them in Release mode with libstdc++ bounds assertions. Test failure checks remain active withNDEBUG.Validation on Windows with Clang 18.1.6 and Eigen 3.4.0:
I have not built the complete GLIM library or run its ROS/viewer/SLAM pipeline locally. The existing full-build workflow is unchanged.