Repository navigation
chore: version packages - #528
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and publish to npm yourself or setup this action to publish automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@lifi/sdk-provider-ethereum@4.2.12
Patch Changes
#521
7d9a726Thanks @Kayanski! - An ERC-20 step can now get its spender from/stepTransaction. Some providers, such as Relay, only know the spender once they build the executable transaction, so the routing-time step carries noestimate.approvalAddress. Before, such a step skipped the allowance tasks, and its transaction went out against a spender with no allowance and reverted.Now a new task runs after the transaction is prepared and before it is signed. When the step had no
approvalAddressbefore prepare and the re-quote brings one, the task reads the allowance for it, and resets and sets it only if it falls short. Inbatched, the approval goes into the batch with the transaction.On a chain with Permit2, the approval goes to the Permit2 contract, as it would before prepare.
A step that already had an
approvalAddressbefore prepare behaves as before, even if the re-quote changes it. The task also does not run when the step skips approval.@lifi/sdk-provider-tron@4.1.10
Patch Changes
#521
7d9a726Thanks @Kayanski! - A TRC-20 step can now get its spender from/stepTransaction. Some providers, such as Relay, only know the spender once they build the executable transaction, so the routing-time step carries noestimate.approvalAddress. Before, such a step skipped the allowance tasks, and its transaction went out against a spender with no allowance and reverted.Now a new task runs after the transaction is prepared and before it is signed. When no allowance was checked before prepare and the re-quote brings an
approvalAddress, the task reads the allowance for it and approves only if it falls short.A step that already had an
approvalAddressbefore prepare behaves as before, even if the re-quote changes it. The task also does not run for native TRX or when the step skips approval.