Repository navigation
Judge the age gate, region block and rate limit checks - #21
Merged
Merged
Conversation
The browser's classify now asks the same twelve presets the local page classifier was trained on. A 429 names is_rate_limited rather than is_blocked, as the classifier's labelling guide does.
Lists the three new classify presets, and picks up structured_data's microdata section from browser main.
The browser now asks whether a page says to slow down as one of judge()'s checks, and a 429 sets it too, so the example drops its own question and the helper that combined the two.
arrufat
marked this pull request as draft
November 3, 2026 15:53
Member
Author
|
Draft until a browser release ships lightpanda-io/browser#4428. Every new check here, and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows lightpanda-io/browser#4428, which makes
classifyask the same twelve presets as the local page classifier.PageVerdictgetsis_age_gate,is_region_blockedandis_rate_limited. A 429 now setsis_rate_limitedinstead ofis_blocked, matching page-classifier'sLABELLING.md; code that checkedis_blockedon a 429 will see the change.Needs a browser with #4428: on an older binary the three attributes are never set, so reading them raises
AttributeError.triage_crawl.pykeeps its ownrate_limitedquestion until a release ships the preset.