Skip to content

Forward icon class to sidebar group icon #2844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ghabriel25 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Forward icon class to sidebar group icon #2844

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2ca904d
Forward icon class to sidebar group icon
ghabriel25 Sep 26, 2026
807f799
Use fixed size
ghabriel25 Sep 27, 2026
f9e4c6b
Cleanup
ghabriel25 Sep 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions stubs/resources/views/flux/sidebar/group.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,18 @@
'icon' => null,
])

@php
$iconClasses = Flux::classes('size-4')
->add($attributes->pluck('icon:class'));
@endphp

<?php if ($expandable && $heading): ?>
<?php if ($icon): ?>
<ui-disclosure {{ $attributes->class('group/disclosure in-data-flux-sidebar-collapsed-desktop:hidden') }} @if ($expanded === true) open @endif data-flux-sidebar-group>
<button type="button" class="border-1 border-transparent w-full min-w-0 h-8 in-data-flux-sidebar-on-mobile:h-10 flex items-center group/disclosure-button my-px rounded-lg hover:bg-zinc-800/5 dark:hover:bg-white/[7%] text-zinc-500 hover:text-zinc-800 dark:text-white/80 dark:hover:text-white">
<div class="px-3">
<?php if (is_string($icon) && $icon !== ''): ?>
<flux:icon :icon="$icon" :variant="$iconVariant" class="size-4" />
<flux:icon :icon="$icon" :variant="$iconVariant" :class="$iconClasses" />
<?php else: ?>
{{ $icon }}
<?php endif; ?>
Expand Down Expand Up @@ -46,7 +51,7 @@
<?php if ($icon): ?>
<div class="relative">
<?php if (is_string($icon) && $icon !== ''): ?>
<flux:icon :icon="$icon" :variant="$iconVariant" class="in-data-flux-menu:text-zinc-400 in-data-flux-menu:dark:text-white/80 in-data-flux-menu:[[data-flux-sidebar-group-dropdown]>button:hover_&]:text-current size-4" />
<flux:icon :icon="$icon" :variant="$iconVariant" :class="$iconClasses->add('in-data-flux-menu:text-zinc-400 in-data-flux-menu:dark:text-white/80 in-data-flux-menu:[[data-flux-sidebar-group-dropdown]>button:hover_&]:text-current')" />
<?php else: ?>
{{ $icon }}
<?php endif; ?>
Expand Down
Loading