Repository navigation
Standardize callout icon class targeting to icon:class (with class:icon backwards compatibility) - #2850
Open
ghabriel25 wants to merge 1 commit into
Open
Standardize callout icon class targeting to icon:class (with class:icon backwards compatibility)#2850ghabriel25 wants to merge 1 commit into
icon:class (with class:icon backwards compatibility)#2850ghabriel25 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Callout component (and its heading sub-component) were the only places still using the older
class:iconattribute for icon class targeting.Everywhere else in Flux, icon-related attributes follow the
icon:*convention (icon:variant,icon:trailing, etc.), and class targeting generally uses the*:classform (input:class, etc.).This PR brings the Callout components in line with the rest of the library.
Changes
icon:classon bothflux:calloutandflux:callout.headingclass:iconworking for backwards compatibility (marked as@deprecatedin a comment)Usage
Same applies to
<flux:callout.heading>.Motivation
Having two different attribute names for the same purpose (
class:iconvsicon:class) is confusing for users and inconsistent with the rest of the component library. Standardizing onicon:classmakes the API more predictable while preserving existing code.