Skip to content

remhos changes - #1141

Merged
pearce8 merged 21 commits into
developfrom
remhos
Mar 31, 2026
Merged

pearce8 merged 21 commits into
developfrom
remhos

Conversation

@rfhaque

@rfhaque rfhaque commented Nov 16, 2025 •

Copy link
Copy Markdown
Collaborator

Description

This PR:

  1. Adds a variant to experiment.py, application.py and package.py for enabling gpu-aware-mpi in remhos
  2. Enables umpire in hypre and mfem
  3. Enables GPU aware MPI in mfem

Adding/modifying a benchmark (docs: Adding a Benchmark)

  • If package.py upstreamed to Spack is insufficient, add/modify repo/benchmark_name/package.py plus: create, self-assign, and link here a follow up issue with a link to the PR in the Spack repo.
  • If application.py upstreamed to Ramble is insufficient, add/modify repo/benchmark_name/application.py plus: create, self-assign, and link here a follow up issue with a link to the PR in the Ramble repo.
  • Add/modify an experiments/benchmark_name/experiment.py to define an experiment

This PR depends on

@rfhaque
rfhaque requested a review from pearce8 November 16, 2025 03:45
@github-actions github-actions Bot added experiment New or modified experiment application labels Nov 16, 2025
@rfhaque rfhaque mentioned this pull request Nov 16, 2025
23 tasks done

@pearce8 pearce8 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to think about GPU-aware MPI

Comment thread experiments/remhos/experiment.py Resolved
Comment thread experiments/remhos/experiment.py Resolved
@pearce8 pearce8 added the WIP A work-in-progress not yet ready to commit label Feb 20, 2026
@pearce8 pearce8 added this to the February 2026 milestone Feb 24, 2026
@rfhaque rfhaque added the ready for review Ready for review label Mar 20, 2026
@pearce8 pearce8 added the changes requested Changes requested label Mar 25, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.04%. Comparing base (55fd82e) to head (7407400).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1141      +/-   ##
===========================================
+ Coverage    62.42%   64.04%   +1.61%     
===========================================
  Files           49       49              
  Lines         3774     3774              
  Branches       326      326              
===========================================
+ Hits          2356     2417      +61     
+ Misses        1404     1343      -61     
  Partials        14       14              

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pearce8 pearce8 removed changes requested Changes requested WIP A work-in-progress not yet ready to commit labels Mar 31, 2026
@pearce8
pearce8 merged commit 18beae2 into develop Mar 31, 2026
21 checks passed
@pearce8
pearce8 deleted the remhos branch March 31, 2026 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

application experiment New or modified experiment ready for review Ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants