Repository navigation
[flang][MIF] Add lowering for EVENT_QUERY #237317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JDPailleux
wants to merge
6
commits into
llvm:main
Choose a base branch
from
SiPearl:mif/event_query
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,444
−13
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
59c4695
[flang][MIF] Add lowering for EVENT_QUERY
JDPailleux 70905bb
Remove useless variable
JDPailleux 5d85d5d
Update flang/include/flang/Optimizer/Dialect/MIF/MIFOps.td
JDPailleux b28dc1f
Applying Eugene's feedback
JDPailleux 47787bb
Update flang/include/flang/Optimizer/Dialect/MIF/MIFOps.td
JDPailleux e6a03a9
Adding more tests + TODO on coindexed COUNT on EVENT_QUERY
JDPailleux File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ExtractCoarrayReffollows only the base of the argument's designator, not its subscripts, so this check does not stop a call with a coindexed object nested in a subscript. You can reproduce this by saving the following torepro.f90and runningflang -fcoarray -S -emit-llvm repro.f90 -o -:The emitted
q_never readsk. It loads the subscript from the localnand stores the count into that element ofa:An array element
ev(n[k])as EVENT ands(n[k])as STAT compile the same way. Without this patch, all three calls stop withnot yet implemented: intrinsic: EVENT_QUERY.The missing image selector isn't specific to EVENT_QUERY: Without this patch,
m = a(n[k])andcall system_clock(count=a(n[k]))also load the subscript from the localn. Could the check look for a coindexed object anywhere in each argument, subscripts included, for example with anevaluate::AnyTraversevisitor? Or would you prefer to leave these forms to the coarray access work in #212777?