Repository navigation
(feat) Add basic mimxrt support. - #402
Open
andrewleech wants to merge 1 commit into
Open
andrewleech wants to merge 1 commit into
andrewleech wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name="lv_conf.h">
<violation number="1" location="lv_conf.h:255">
`LV_USE_PXP` is still the controlling flag for this block, but the new guard defines `LV_USE_DRAW_PXP` instead, leaving `LV_USE_PXP` undefined so the feature can never be enabled.</violation>
</file>
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Ask questions if you need clarification on any suggestion
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
andrewleech
force-pushed
the
mimx
branch
3 times, most recently
from
November 13, 2025 04:35
17c31f7 to
09a4d3c
Compare
andrewleech
force-pushed
the
mimx
branch
2 times, most recently
from
July 16, 2026 06:03
4fa7830 to
9a2fffa
Compare
Enable NXP's PXP 2D accelerator for the mimxrt port by setting LV_USE_PXP, LV_USE_DRAW_PXP, LV_USE_GPU_NXP_PXP and LV_USE_GPU_NXP_PXP_AUTO_INIT via CFLAGS_USERMOD, since the mimxrt port has no board-level makefile of its own to provide them. Silence known PXP driver warnings that would otherwise fail a -Werror build. Guard LV_USE_PXP, LV_USE_DRAW_PXP, LV_USE_ROTATE_PXP and LV_DRAW_BUF_ALIGN with #ifndef so a board can override any of these from its own build flags without a macro redefinition warning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm working on getting LVGL working cleanly on the NXP 1170 EVK with a LVGL v9 compatible driver in progress here: https://github.com/andrewleech/imxrt1170_display_driver
These minimal changes to the LVGL bindings files enables the build environment to enable port specific features more easily.
Summary by cubic
Adds basic NXP i.MX RT (mimxrt) port support so LVGL v9 runs on the RT1170 EVK with PXP acceleration, enabled per port in the build.
mimxrtblock inmicropython.mkenablesLV_USE_PXP,LV_USE_DRAW_PXP,LV_USE_GPU_NXP_PXP, andLV_USE_GPU_NXP_PXP_AUTO_INITviaCFLAGS_USERMODand relaxes specific PXP driver warnings so a-Werrorbuild stays clean.LV_DRAW_BUF_ALIGN,LV_USE_PXP,LV_USE_DRAW_PXP, andLV_USE_ROTATE_PXPwith#ifndefinlv_conf.hso boards can override them via build flags without redefinition warnings.Written for commit ca45a77. Summary will update on new commits.