Repository navigation
Conversation
Mohiiit
changed the base branch from
perf/blockifier-hash-cache-runtime-config
to
dev
November 4, 2026 02:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cairo Native computed the wrong array stride for tuples containing dictionary entries, causing native execution to return 33 where Cairo VM returns 22. Pin the madara-alliance Cairo Native fork at
57e745e1a7883ec07cd8e6d721cc02036a112a89, which fixes this layout discrepancy (madara-alliance/cairo_native#1).This change preserves the Alliance dev integration line, including the deployed hash-cache work and the existing SNOS Patricia optimizations. Blockifier and the native compiler resolve to the same fixed revision, and dependency resolution passes with the locked graph. The focused VM/native regression fails against the old implementation and passes with the fix across all four optimization levels. The full sequencer suite has not been run.
Madara consumers must align their own Cairo Native dependency and sequencer pins; that integration is scoped to madara-alliance/madara#1306. This change does not recover previously committed inconsistent state.
Upstream status: starkware-libs/cairo_native#1671 fixes the same dictionary-entry layout on main and is included in v0.9.0-rc.9; v0.9.0-rc.8 still contains the bug. This narrowly scoped backport retains the deployed rc.6/Cairo 2.17 dependency line and Pedersen cache extensions. The newer upstream line uses Cairo 2.19.6.