Skip to content

Skip empty speech nodes and don't show 'none' character in subtitles. (mathjax/MathJax#3618) - #1581

Merged
dpvc merged 2 commits into
developfrom
issue3618
Oct 21, 2026
Merged

dpvc merged 2 commits into
developfrom
issue3618

Conversation

@dpvc

@dpvc dpvc commented Oct 20, 2026 •

Copy link
Copy Markdown
Member

This PR causes the key explorer to skip nodes with empty speech (or speech set to "none") and also prevents the subtitles from showing the "none" character (just in case). This avoids a situation where the explorer moves to a node with no speech, which can be confusing when nothing is spoken.

Resolves issue mathjax/MathJax#3618.

@codecov

codecov Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.13%. Comparing base (e521742) to head (da04dfd).
⚠️ Report is 7 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##           develop    #1581     +/-   ##
==========================================
  Coverage    87.13%   87.13%             
==========================================
  Files          392      392             
  Lines        89279    89280      +1     
  Branches      5079     3386   -1693     
==========================================
+ Hits         77793    77794      +1     
  Misses       11486    11486             

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dpvc dpvc changed the title Skip empty speech nodes and don't show 'none' character in subtitles Skip empty speech nodes and don't show 'none' character in subtitles. (mathjax/MathJax#3618) Oct 20, 2026
@dpvc
dpvc requested a review from zorkow October 20, 2026 10:43
@dpvc dpvc added this to the v4.2 milestone Oct 20, 2026

@zorkow zorkow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion of a refactor. O/w works fine.

Comment thread ts/a11y/explorer/KeyExplorer.ts Outdated
@dpvc
dpvc merged commit 40a284d into develop Oct 21, 2026
1 check passed
@dpvc
dpvc deleted the issue3618 branch October 21, 2026 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants