Repository navigation
ci(release): adopt the gutenberg release pipeline - #238
Conversation
Claude review status
✅ Review clean Last reviewed: New this round: 0 finding(s), 0 question(s) · Resolved this round: 0 · Open questions: 0 |
There was a problem hiding this comment.
0 blocking · 0 should-fix · 1 suggestion(s) · 0 open question(s)
Reviewed head 2e16a3ba.
Findings without inline anchors:
.github/workflows/on-release.yml:30— [Minor] Comment still references the oldpublishenvironment after theregistryjob was moved toreleaseAn operator reading the header to confirm where to configure the secret is pointed at the wrong GitHub environment (publish), while the job actually resolves credentials fromrelease. The PR body already lists A3 (add GCP_AUTH_KEY to environment release before the first tag) as a prerequisite; a stale comment that still claims the secret lives inpublishdirectly contradicts that prerequisite and increases the chance the registry upload fails on the first real release. Suggested fix: Update the comment to say the secret lives in thereleaseenvironment (and that its deployment policy must allowv*tag refs, matching A2 in the PR body), so the orientation comment and theenvironment:on line 134 stay in sync.
Summary
Migrates the release workflows from Maxwell/
release-publishto the shared Gutenberg release pipeline (megaeth-labs/.githubmain; guide: https://github.com/megaeth-labs/.github/blob/main/.github/actions/RELEASE.md).release-candidate.yml: Gutenberg token (permission-*listed), push-to-mainroute+cut, no job environment;bump_command: cargo update --workspacekept withdependency_token: ${{ github.token }}(algebra, salt, mega-evm are all public).release-settle.yml: PR-basedroute/refresh/publish; onlypublishusesenvironment: release.release-publish.yml: deleted (publish now happens in release-settle).on-release.yml:registryjobenvironment: publish->release; nothing else changed.app-token-lint.yml: new, linting only the four release files (notclaude.yml, which mints Maxwell without permissions).Owner Phase A prerequisites (console checklist, stateless-validator)
MEGA_GUTENBERG_CLIENT_ID/ secretMEGA_GUTENBERG_PKare visible to this repo and the mega-gutenberg app installation covers it.release: keep branchmain, add branchrelease-v*and tagv*; keep reviewer Troublor.GCP_AUTH_KEYto environmentreleasebefore the first tag (today it exists only inpublish).lint/test, enable do-not-enforce-on-create and up-to-date branches.Notes
dependency_token); after merge it can simply be re-dispatched.chore/release-candidate-2.0.18,chore/release-candidate-2.0.19,chore/release-settle-v2.0.18are intentionally left alone.