Repository navigation
fix(audit): follow the repository renames and the msime consolidation - #28
Merged
Merged
Conversation
健康策略按旧仓库名登记,改名后 msime、msime-windows、msime-web、chinese-ime-lm、msime-skin-example 全被报成没有策略;产品锁检查还在读 MSIME-Apple 的 product-lock.json 和已归档 MSIME-Engine 的提交历史,永远报 unreadable。 策略只改键名:msime 的 release.yml 换成实际在 main 上发版的 release-macos.yml 与 release-ios.yml,msime-web 的 update-manifest.yml 换成合并后的 sync-downloads.yml(#170),删去已归档的 MSIME-Engine 与 MSIME-Linux。产品锁改为比对 msime-windows 的 product-lock.json 与 msime 的 resources/desktop-dictionary.lock.json,两种格式先归一化再沿用原有比对规则;引擎已并入各产品仓,引擎 pin 比对不再接入审计,函数与测试保留。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The daily organization audit has failed every day since the repository renames and the msime consolidation, and most of its findings were caused by the audit itself, not by the repositories.
Health policy (
tools/health-policy.json) is keyed by repository name, so the renamed repositories were all reported as "No health policy". Keys are renamed with the policy content unchanged; the required checks already match each repository's current ruleset:MSIME-Windows→msime-windows,Metasequoia-n-gram→chinese-ime-lm,metasequoia-ime-skin-example→msime-skin-example: key only.MSIME-Apple→msime:release.ymlno longer exists; replaced byrelease-macos.ymlandrelease-ios.yml, the two release workflows that actually run onmain. The other four platform release workflows have never run onmainand are not registered yet.require_pris nowtrue, matching thepull_requestrule ondevelop.MSIME-Web→msime-web:update-manifest.ymlwas merged intosync-downloads.ymlin fix(automation): publish 0.8.0 and stop the two download manifests from deadlocking each other msime-web#170.MSIME-EngineandMSIME-Linuxare removed; the audit skips archived repositories, so these entries were dead.Product locks (
tools/product_locks.py) comparedproduct-lock.jsonin MSIME-Windows, MSIME-Apple and MSIME-Linux plus their engine submodule pins. It now comparesmsime-windows/product-lock.jsonwithmsime/resources/desktop-dictionary.lock.json. The msime lock lists download artifacts, sonormalize_lockconverts it to the product-lock shape: only artifacts from adict-*release count (the same list carries the sentence model fromchinese-ime-lm), and the repository name is compared in lower case (MSIME-Enginevsmsime-engine). The comparison rules themselves are unchanged.The engine now lives inside each product repository, so the engine pin comparison and the paginated fetch of the archived MSIME-Engine history are no longer called.
engine_pin_reportand its tests are kept.Repositories with no required checks yet (
msime-cloud,msime-customdict,homebrew-tap,msime-skins,ime-dictionary) are deliberately not given a policy; which checks they should require is a maintainer decision, and the "No health policy" finding is the prompt for it.Decision needed: dictionary versions
With the lock check working again, it reports that the two products pin different dictionary releases:
msimeusesdict-v2.0.1,msime-windowsstill usesdict-v1.0.0. Under the existing rules that is a problem (tag, source commit and three asset digests differ). Either Windows should move todict-v2.0.1, or a tag difference should become a note and only "same tag, different digest" should fail. This PR keeps the existing rule.Verification
python -m unittest discover -s tests: 28 tests OK, including new cases for both lock formats, the model-artifact filter, case-insensitive repository names and a lock spanning two dictionary releases.python tools/audit_repositories.py --healthlocally against the live organization (GET requests only). Compared with the last scheduled run (36706750667):msime,msime-windows,msime-web,chinese-ime-lm,msime-skin-example;MSIME-Apple: product-lock.json is unreadable.msimeCodeQL failing on schedule with one run stuck for over 3 hours;msime-windowsrelease.ymllast three runs failed;msime-webCodeQL not run in 240 hours andsync-downloads.ymlnot run in 6 hours;msime-skin-exampleCodeQL with no success in 240 hours; the dictionary version difference above.Google-PinyinIME-Rev,pinyin_cppandpinyin_python.The audit stays red after this PR; every remaining finding is a real one. The
coveragejob in this PR's checks will also fail onhomebrew-tapandmsime-skinshaving no.githubdirectory, which predates this change.