Repository navigation
Conversation
msime-windows deliberately stays on the legacy MSIME-Engine dictionary (dict-v1.0.0) and is not being migrated to the msime-dictionary releases the msime monorepo ships. The two pin different repositories, tags and files, so the cross-platform comparison only ever reported that known difference and kept the daily coverage audit red.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The daily "Organization CI coverage" audit has failed every day since 2026-10-19, partly on three product-lock findings: msime-windows pins
metasequoiaime/MSIME-Enginedict-v1.0.0while msime pinsmetasequoiaime/msime-dictionarydict-v2.0.24. That is intentional: msime-windows stays on the legacy dictionary (msime.db,others.db,english.db), whose files differ from the msime-dictionary releases (msime-pinyin.db,msime-wubi.db, bigram and trigram), and it is not being migrated. The comparison could only ever report that known difference.Changes
PLATFORM_LOCKSno longer lists msime-windows; the module docstring says why. The comparison machinery and its tests are unchanged, so another platform pinning the shared dictionary can be added back.Verification
python3 -m unittest discover -s tests: 28 tests pass.product_lock_findings('metasequoiaime')against the live repositories returns no problems and no notes.The audit's other findings (missing CI baseline in msime-cloud, msime-dictionary, homebrew-tap and msime-skins) are fixed in their own repositories: metasequoiaime/msime-cloud#1562, metasequoiaime/msime-dictionary#98, metasequoiaime/homebrew-tap#1, metasequoiaime/msime-skins#1.