Skip to content

fix(audit): stop comparing msime-windows's dictionary lock - #36

Open
houko wants to merge 1 commit into
mainfrom
fix/dictionary-lock-migration
Open

houko wants to merge 1 commit into
mainfrom
fix/dictionary-lock-migration

Conversation

@houko

@houko houko commented Oct 27, 2026

Copy link
Copy Markdown
Member

Why

The daily "Organization CI coverage" audit has failed every day since 2026-10-19, partly on three product-lock findings: msime-windows pins metasequoiaime/MSIME-Engine dict-v1.0.0 while msime pins metasequoiaime/msime-dictionary dict-v2.0.24. That is intentional: msime-windows stays on the legacy dictionary (msime.db, others.db, english.db), whose files differ from the msime-dictionary releases (msime-pinyin.db, msime-wubi.db, bigram and trigram), and it is not being migrated. The comparison could only ever report that known difference.

Changes

  • PLATFORM_LOCKS no longer lists msime-windows; the module docstring says why. The comparison machinery and its tests are unchanged, so another platform pinning the shared dictionary can be added back.

Verification

  • python3 -m unittest discover -s tests: 28 tests pass.
  • Running product_lock_findings('metasequoiaime') against the live repositories returns no problems and no notes.

The audit's other findings (missing CI baseline in msime-cloud, msime-dictionary, homebrew-tap and msime-skins) are fixed in their own repositories: metasequoiaime/msime-cloud#1562, metasequoiaime/msime-dictionary#98, metasequoiaime/homebrew-tap#1, metasequoiaime/msime-skins#1.

msime-windows deliberately stays on the legacy MSIME-Engine dictionary (dict-v1.0.0) and is not being migrated to the msime-dictionary releases the msime monorepo ships. The two pin different repositories, tags and files, so the cross-platform comparison only ever reported that known difference and kept the daily coverage audit red.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant