Skip to content

Speed up equal_degree_factors in even characteristic. - #655

Merged
mhostetter merged 5 commits into
mhostetter:developfrom
bwesterb:main
May 2, 2026
Merged

mhostetter merged 5 commits into
mhostetter:developfrom
bwesterb:main

Conversation

@bwesterb

@bwesterb bwesterb commented Feb 5, 2026

Copy link
Copy Markdown
Contributor

Summary

Speeds up equal_degree_factors in even characteristic.

Type

  • Fix (bug / correctness)
  • Feature (new capability)
  • Performance
  • Docs / tooling / CI
  • Refactor (no behavior change)

Release notes

  • Not user-facing (no entry needed)
  • Added entry to docs/release-notes/unreleased.md

Testing

  • Added/updated tests
  • pytest (command / notes):
  • Other validation (benchmarks, docs build, examples):

Backwards compatibility

  • No breaking changes
  • Potentially breaking (describe + rationale)

Checklist

  • PR base branch is develop
  • CI is green
  • Docs/docstrings updated where appropriate

@mhostetter

Copy link
Copy Markdown
Owner

Sorry, I think I missed this. Thanks for submitting.

Is this a bug fix? Can you summarize the bug and fix? Or is it a performance improvement?

@bwesterb

Copy link
Copy Markdown
Contributor Author

Would you call a sort function that takes O(n^2) time a performance issue or a bug? Anyway, it's like that: in even characteristic the present algorithm doesn't work well and comes down to guessing a factor. See #654 for the details.

@mhostetter
mhostetter changed the base branch from main to develop May 2, 2026 11:11
@codecov

codecov Bot commented May 2, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 95.14%. Comparing base (eca60fb) to head (8b1773f).
⚠️ Report is 8 commits behind head on develop.

Files with missing lines Patch % Lines
src/galois/_polys/_factor.py 93.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #655      +/-   ##
===========================================
- Coverage    95.22%   95.14%   -0.09%     
===========================================
  Files           48       48              
  Lines         6244     6257      +13     
===========================================
+ Hits          5946     5953       +7     
- Misses         298      304       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bwesterb

bwesterb commented May 2, 2026

Copy link
Copy Markdown
Contributor Author

Change to PR lgtm.

@mhostetter
mhostetter merged commit 209ade7 into mhostetter:develop May 2, 2026
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants