Repository navigation
Speed up equal_degree_factors in even characteristic. - #655
Merged
Merged
Conversation
Owner
|
Sorry, I think I missed this. Thanks for submitting. Is this a bug fix? Can you summarize the bug and fix? Or is it a performance improvement? |
Contributor
Author
|
Would you call a sort function that takes O(n^2) time a performance issue or a bug? Anyway, it's like that: in even characteristic the present algorithm doesn't work well and comes down to guessing a factor. See #654 for the details. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #655 +/- ##
===========================================
- Coverage 95.22% 95.14% -0.09%
===========================================
Files 48 48
Lines 6244 6257 +13
===========================================
+ Hits 5946 5953 +7
- Misses 298 304 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Change to PR lgtm. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Speeds up equal_degree_factors in even characteristic.
Type
Release notes
docs/release-notes/unreleased.mdTesting
pytest(command / notes):Backwards compatibility
Checklist
develop