Skip to content

Three small bug fixes - #656

Merged
mhostetter merged 3 commits into
mhostetter:developfrom
dimbleby:bug-fixes
Mar 14, 2026
Merged

mhostetter merged 3 commits into
mhostetter:developfrom
dimbleby:bug-fixes

Conversation

@dimbleby

Copy link
Copy Markdown
Contributor

Summary

Three very small bug fixes.

I have been having fun recently pointing our AI friends at projects that interest me and asking for bugs.

I am human - what a world where I feel the need to say such things! - and responsible for this pull request: but that is how we got here.

Type

  • Fix (bug / correctness)
  • Feature (new capability)
  • Performance
  • Docs / tooling / CI
  • Refactor (no behavior change)

Release notes

  • Not user-facing (no entry needed)
  • Added entry to docs/release-notes/unreleased.md

Testing

  • Added/updated tests
  • pytest (command / notes):
  • Other validation (benchmarks, docs build, examples):

Backwards compatibility

  • No breaking changes
  • Potentially breaking (describe + rationale)

Checklist

  • PR base branch is develop
  • CI is green
  • Docs/docstrings updated where appropriate

@mhostetter

Copy link
Copy Markdown
Owner

This is fantastic. Thank you!

I appreciate the atomic commits and unit tests. Did all of the unit tests fail before the fixes?

I'll work on getting this merged, soon-ish. Will definitely be published in the next release.

@mhostetter mhostetter added the bug-fix Fixes a reported bug label Mar 11, 2026
@codecov

codecov Bot commented Mar 11, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.18%. Comparing base (eca60fb) to head (924f860).
⚠️ Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #656      +/-   ##
===========================================
- Coverage    95.22%   95.18%   -0.05%     
===========================================
  Files           48       48              
  Lines         6244     6246       +2     
===========================================
- Hits          5946     5945       -1     
- Misses         298      301       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dimbleby

Copy link
Copy Markdown
Contributor Author

Did all of the unit tests fail before the fixes?

yes - each test fails without its fix

@mhostetter
mhostetter changed the base branch from main to develop March 14, 2026 13:04
@mhostetter
mhostetter merged commit 5621e5b into mhostetter:develop Mar 14, 2026
47 checks passed
@mhostetter

Copy link
Copy Markdown
Owner

Thank you!

@dimbleby
dimbleby deleted the bug-fixes branch March 14, 2026 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug-fix Fixes a reported bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants