Repository navigation
docs: add image citation for ComputeGraphGrad.png (#714) - #772
Open
viwe-monai wants to merge 1 commit into
Open
viwe-monai wants to merge 1 commit into
viwe-monai wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #714
What
Replaces the
> TODO: image citationplaceholder underimages/ComputeGraphGrad.pnginlessons/3-NeuralNetworks/04-OwnFramework/README.mdwith the attribution format already used elsewhere in the repo:One-line diff, scoped to the citation line only.
Provenance evidence
The image is original course material created by the course author, Dmitry Soshnikov — it is not from a third-party source. Evidence:
git log --followonimages/ComputeGraphGrad.png, originally at3-NeuralNetworks/04-OwnFramework/images/ComputeGraphGrad.pngbefore the 2022-04-29 repo restructure in9277c42b): the image was added in commit5e416b31(2021-09-29) by Dmitri Soshnikov<dmitri@soshnikov.com>in "Finish 1st iteration of ownframework" — the commit where he wrote the lesson itself. The same commit added the lesson's other custom diagrams (ComputeGraph.png,NeuroArch.png,Cross-Entropy-Loss.png,overfit.png) and the README.> TODO: image citationline was inserted by the copyedit commit3a3a2857(2022-04-26, Jen Looper, "chapter 4 copyedits") as a generic marker — not evidence of external origin.a96da961(2022-04-05) "Add image attributions", where his own custom diagrams are cited as> Image by [Dmitry Soshnikov](http://soshnikov.com)(e.g.lessons/1-Intro/README.md,lessons/4-ComputerVision/09-Autoencoders/README.md), and third-party images as> Image from [source](url). This PR uses the author-image format verbatim.z₁=w₁x+b₁,z₂=w₂α(z₁)+b₂,f=σ(z₂), gradient labels along the backward edges) matches the surrounding README text exactly. No watermark or third-party branding; a web search for the filename finds no external occurrence of the diagram.So the truthful fix is a citation to the course author (this is a self-citation of original course material, in the repo's established format), not to an external source.