Repository navigation
fix(testing): use arePathsSame when comparing resolvedPath and cwd in pytest symlink check - #26229
Open
MOHAMMED WASIM KHAN (wasim-builds) wants to merge 1 commit into
Conversation
…est symlink check Fixes microsoft#26050
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26050
Summary
In
handleSymlinkAndRootDir,resolvedPathis compared tocwdusing strict identity (resolvedPath !== cwd). On case-insensitive file systems (such as Windows, where drive letters or paths may differ only by case likec:\clones\python-soundfilevsC:\clones\python-soundfile), this caused a false positive warning:Working directory resolves to different path: ${cwd} -> ${resolvedPath}. Checking for symlinks in parent directories.and triggered unnecessary recursive parent directory symlink checks.
This PR:
resolvedPath !== cwdwith!arePathsSame(resolvedPath, cwd)using the extension's cross-platformarePathsSamehelper.handleSymlinkAndRootDirverifying that parent symlink checking is bypassed when paths differ only by casing on case-insensitive filesystems while still properly checking parents when paths truly resolve to different locations.