Repository navigation
refactor(exporters): read the exporter's style through its engine - #67
Merged
Merged
Conversation
XCCDFExporter.config is a read-only property returning engine.config, so the style has one home: an exporter given another engine writes that engine's style, and tests no longer rebind both. The 28 exports are byte-identical. Refs: cis-bench-fh9l.16 Signed-off-by: Aaron Lippold <lippold@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XCCDFExporter.configis now a read-only property that returnsengine.config, so the exporter no longer keeps a second copy of the style. An exporter given another engine now writes that engine's style. The three tests that rebound both now set only the engine.Checks:
tests/scripts, mypy, ruff andmkdocs build --strictpass.nextand passcis-bench validate.Card: cis-bench-fh9l.16, a follow-up from the review of cis-bench-fh9l.9.