Repository navigation
Conversation
Packet::Packet and Fragment::Fragment read 16-bit header fields by casting the input string's char storage to uint16_t* and indexing it. That is a strict- aliasing violation (undefined behavior the optimizer may miscompile) and an unaligned load that faults on strict-alignment architectures such as ARM and SPARC. The adjacent 64-bit id read already used memcpy; this makes the 16-bit reads consistent. Behavior is byte-for-byte identical (cppcheck dangerousTypeCast).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Casting
char*touint16_t*is a strict-aliasing violation and an unaligned load, which faults on ARM/SPARC. The reads now use memcpy, matching the 64-bit read next to them.