Repository navigation
ci: hash-check old forge tarball and all solc before use - #203
Conversation
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e6b82961e0
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
forge-old now downloads the old Foundry release tarball directly from GitHub and checks its sha256 before running anything, instead of installing it through foundry-toolchain, which runs the latest foundryup before the hash check. Every solc version the tests need is pre-installed with a pinned sha256, and forge runs with
--offlineso it cannot fetch an unchecked compiler. The bytecode comparison against latest forge is removed.