Skip to content

ci: hash-check old forge tarball and all solc before use - #203

Merged
QGarchery merged 8 commits into
mainfrom
devin/1793812386-hash-pin-old-forge
Nov 6, 2026
Merged

QGarchery merged 8 commits into
mainfrom
devin/1793812386-hash-pin-old-forge

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

forge-old now downloads the old Foundry release tarball directly from GitHub and checks its sha256 before running anything, instead of installing it through foundry-toolchain, which runs the latest foundryup before the hash check. Every solc version the tests need is pre-installed with a pinned sha256, and forge runs with --offline so it cannot fetch an unchecked compiler. The bytecode comparison against latest forge is removed.

@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-05T09:28:39.458536Z c7803a1 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e6b82961e0

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread .github/workflows/forge-old.yml Resolved
@QGarchery
QGarchery merged commit 3537d00 into main Nov 6, 2026
17 checks passed
@QGarchery
QGarchery deleted the devin/1793812386-hash-pin-old-forge branch November 6, 2026 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants