Repository navigation
Conversation
|
This PR is part of a stack of 4 bookmarks:
Created with jj-stack |
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No blocking issues remain, and the trait change is consistent with the documented compatibility policy for main.
Review effort: Balanced
Findings: None
What changed in this PR
Exposes per-session outgoing datagram queue capacity through the WebTransport client API.
Changes:
- Adds a capacity accessor with WebTransport session validation.
- Preserves outgoing datagram statistics during session cleanup.
- Tests queue isolation, invalid session IDs, and cleanup accounting.
| File | Description |
|---|---|
| neqo-http3/tests/connect_udp.rs | Tests rejection of CONNECT-UDP sessions. |
| neqo-http3/src/webtransport.rs | Exposes the client capacity accessor. |
| neqo-http3/src/features/extended_connect/tests/webtransport/datagrams.rs | Tests capacity isolation and cleanup statistics. |
| neqo-http3/src/features/extended_connect/session.rs | Makes the capacity helper available outside tests. |
| neqo-http3/src/connection.rs | Validates capacity requests and records cleanup statistics. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## users/jesup/report_datagrams #4037 +/- ##
=============================================================
Coverage 97.00% 97.00%
=============================================================
Files 118 118
Lines 41878 41883 +5
Branches 41878 41883 +5
=============================================================
+ Hits 40625 40630 +5
Misses 1227 1227
Partials 26 26
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Merging this PR will regress 2 benchmarks
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing |
0989fca to
46d208c
Compare
f039ffc to
8b15031
Compare
46d208c to
81c0a1c
Compare
8b15031 to
3becb80
Compare
81c0a1c to
06d84c1
Compare
3becb80 to
9201b51
Compare
|
@jesup clippy is unhappy |
06d84c1 to
3a436bb
Compare
9201b51 to
85fd2d6
Compare
3a436bb to
b235f68
Compare
85fd2d6 to
09773fc
Compare
b235f68 to
1eebcea
Compare
8acfbd3 to
93b5b24
Compare
09773fc to
c9d3c36
Compare
Add a production-facing Http3Client::webtransport_datagram_queue_capacity, so a caller (e.g. a content-process credit grant) can read a session's outgoing-datagram queue state without going through the test-only path. The underlying transport-level DatagramQueueCapacity snapshot and per-session accessor already existed but were only reachable from #[cfg(test)] code; drop that gate now that there's a real caller.
62589ab to
6325866
Compare
c9d3c36 to
4c6d5b8
Compare
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-pr as client
neqo-pr as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-pr as client
neqo-pr as server
|
Client/server transfer resultsPerformance differences relative to 6325866. Transfer of 33554432 bytes over loopback, min. 100 runs. All unit-less numbers are in milliseconds.
Table above only shows statistically significant changes. See all results below. All resultsTransfer of 33554432 bytes over loopback, min. 100 runs. All unit-less numbers are in milliseconds.
Download data for |
No description provided.