[dadachi]

Problem

The destroy actions (accounts, shops, item_tags, members, invitations, devices) ignored destroy's return value and always answered 200 or 204.

Nothing fails this way today:

• No model halts its own destroy.
• The owner-removal guard is a controller before_action.
• Hard failures raise, and since Return API errors as JSON regardless of request headers #115 they come back as JSON.

But a before_destroy guard added later would leave the record in place behind a success response.

Fix

• Use destroy! in all six actions.
• rescue_from ActiveRecord::RecordNotDestroyed in Api::V1::Shopkeeper::BaseController. It answers 422 {code, error_message} with the record's errors, or "Could not be deleted." when there are none.

Verification

• Test-first: test/integration/destroy_failure_test.rb adds a temporary before_destroy { throw :abort } to each model in turn, calls its endpoint, and expects 422 with the record kept. On the old code this got 200.
• Red check:
  • Reverting each action to destroy fails the test at that action's own step.
  • Removing the rescue_from raises RecordNotDestroyed.
• Dev server: normal deletes are unchanged; item tag and shop deletes both return {"status":200}. The probe records are gone.
• bin/rails test: 498 runs, 0 failures. rubocop and brakeman are clean.

🤖 Generated with Claude Code

https://claude.ai/code/session_01L4Pma9VAqB5A22KCEEin9R