Repository navigation
Fixes #23473: Enable filtering Circuits, Virtual Circuits and their terminations by Provider Network name - #23474
Merged
jeremystretch merged 1 commit intoOct 27, 2026
Conversation
Circuits, circuit terminations, virtual circuits and virtual circuit terminations offered only provider_network_id, so a provider_network query parameter was ignored. Each now matches provider networks by name, including names shared across providers. Fixes #23473
pheus
marked this pull request as ready for review
October 22, 2026 14:55
pheus
requested review from
a team and
bctiemann
and removed request for
a team
October 22, 2026 14:55
jeremystretch
requested review from
jeremystretch
and removed request for
bctiemann
October 27, 2026 12:15
jeremystretch
approved these changes
Oct 27, 2026
jeremystretch
deleted the
23473-circuit-terminations-cannot-be-filtered-by-provider-network
branch
October 27, 2026 12:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #23473
The REST API ignored
provider_networkfor circuits, virtual circuits and their terminations. This adds the missing name-based filters alongsideprovider_network_id, including support for names shared across providers.Filterset tests cover all four filters and the shared-name case.